-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Add fraction size parameter to currencyFilter #7582
Conversation
currencyFilter now accepts fractionSize so it behaves "similar" to a numberFilter, it even uses locale patterns
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
I just sent the email with the signed CLA for my company. I'm guessing that's it. Please, @mary-poppins, let me know if I need to do something else. |
I updated the title to reflect the changes |
I think this could be combined with #5672 |
Yes @petebacondarwin, you might be right. I think I should also update the tests... I'll do it soon! "My" fix is much "easier", since I was trying to reproduce the behavior of the numberFormat, #5672 does some aditional behavior, which I dont entirely agree with. |
If you look at the code, #5672 does not 'extend' behavior. It make code that was already there doing nothing actually get run. I just made the original intent not broken. |
Also I totally already did this and wrote tests for it in #5674. |
Let's hope angular folks add the feature! ;) @park9140 @petebacondarwin 👯 |
feat(filter): currencyFilter and numberFilter should have same fraction behavior
currencyFilter now accepts fractionSize so it behaves "similar" to a numberFilter, it even uses locale patterns by default.